Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove package lock #1338

Merged
merged 2 commits into from
Jun 22, 2017
Merged

Remove package lock #1338

merged 2 commits into from
Jun 22, 2017

Conversation

shilman
Copy link
Member

@shilman shilman commented Jun 22, 2017 •
edited
Loading

Issue: N/A

What I did

Travis builds like this one (#1337) are failing mysteriously all of a sudden. The only recent change that could be related (AFAIK) is my addition of npm5's package-lock.json to the repo.

This change removes all package-lock.json files, and also adds them to gitignore for now.

How to test

@shilman shilman requested a review from tmeasday June 22, 2017 15:08
@shilman shilman requested a review from ndelangen June 22, 2017 15:08
@storybookbot
Copy link
Collaborator

Fails
🚫

PR is not labeled with one of: ["cleanup","breaking","feature","bug","documentation","maintenance","greenkeeper","other"]

Generated by 🚫 dangerJS

@codecov
Copy link

codecov bot commented Jun 22, 2017 •
edited
Loading

Codecov Report

Merging #1338 into master will increase coverage by 4.32%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1338      +/-   ##
==========================================
+ Coverage    9.43%   13.76%   +4.32%     
==========================================
  Files         204      202       -2     
  Lines        4630     4621       -9     
  Branches      518      588      +70     
==========================================
+ Hits          437      636     +199     
+ Misses       3716     3464     -252     
- Partials      477      521      +44
Impacted Files Coverage Δ
addons/storyshots/src/require_context.js 0% <0%> (ø) ⬆️
addons/knobs/src/components/PropForm.js 8.51% <0%> (ø) ⬆️
addons/knobs/src/components/PropField.js 10.86% <0%> (ø) ⬆️
lib/ui/src/modules/api/configs/init_api.js 40.47% <0%> (ø) ⬆️
app/react/src/client/preview/init.js 0% <0%> (ø) ⬆️
lib/ui/src/modules/ui/routes.js 0% <0%> (ø) ⬆️
app/react/src/client/preview/reducer.js 0% <0%> (ø) ⬆️
app/react-native/src/bin/storybook-build.js 0% <0%> (ø) ⬆️
...src/server/config/WatchMissingNodeModulesPlugin.js 0% <0%> (ø) ⬆️
lib/ui/src/context.js 0% <0%> (ø) ⬆️
... and 46 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0520eab...7787b9b. Read the comment docs.

@shilman shilman added the maintenance User-facing maintenance tasks label Jun 22, 2017
ndelangen
ndelangen approved these changes Jun 22, 2017
View reviewed changes
Copy link
Member

@ndelangen ndelangen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕶

@shilman shilman merged commit bf6faea into master Jun 22, 2017
@shilman shilman deleted the remove-package-lock branch June 22, 2017 22:04
@shilman shilman mentioned this pull request Jun 23, 2017
Closed
@tmeasday tmeasday mentioned this pull request Jun 23, 2017
Closed
@dependencies dependencies bot mentioned this pull request Nov 11, 2017
Merged
This was referenced Sep 19, 2018
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndelangen ndelangen ndelangen approved these changes

@tmeasday tmeasday Awaiting requested review from tmeasday tmeasday is a code owner

Assignees
No one assigned
Labels
maintenance User-facing maintenance tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shilman @storybookbot @ndelangen